Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allowing group data download button to apply to selected rows #1230

Merged
merged 1 commit into from
May 22, 2024

Conversation

alex-sheehan-edx
Copy link
Contributor

@alex-sheehan-edx alex-sheehan-edx commented May 20, 2024

https://2u-internal.atlassian.net/browse/ENT-8974

image

For all changes

  • Ensure adequate tests are in place (or reviewed existing tests cover changes)

Only if submitting a visual change

  • Ensure to attach screenshots
  • Ensure to have UX team confirm screenshots

Copy link

codecov bot commented May 20, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 85.37%. Comparing base (5ffab67) to head (1da866a).

Files Patch % Lines
src/data/services/EnterpriseAccessApiService.js 0.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1230      +/-   ##
==========================================
- Coverage   85.39%   85.37%   -0.02%     
==========================================
  Files         537      537              
  Lines       11684    11689       +5     
  Branches     2430     2468      +38     
==========================================
+ Hits         9977     9980       +3     
  Misses       1657     1657              
- Partials       50       52       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alex-sheehan-edx alex-sheehan-edx force-pushed the asheehan-edx/ENT-8974 branch 2 times, most recently from 707adfc to 1568b64 Compare May 20, 2024 18:35
Copy link
Contributor

@katrinan029 katrinan029 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good so far! I just had some nits on how we can use options to capture the selected emails rather than passing additional params

@alex-sheehan-edx alex-sheehan-edx force-pushed the asheehan-edx/ENT-8974 branch 2 times, most recently from a5cd207 to e32c0fa Compare May 21, 2024 15:45
@alex-sheehan-edx alex-sheehan-edx merged commit 5a3982c into master May 22, 2024
4 of 6 checks passed
@alex-sheehan-edx alex-sheehan-edx deleted the asheehan-edx/ENT-8974 branch May 22, 2024 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants